Close the connection of ad hoc kubernetes client (#550)

spring-cloud · Apr 20, 2020 · 5a28981 · 5a28981
1 parent 67783ae
commit 5a28981
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/...g/springframework/cloud/kubernetes/profile/KubernetesProfileEnvironmentPostProcessor.java b/...g/springframework/cloud/kubernetes/profile/KubernetesProfileEnvironmentPostProcessor.java
@@ -49,9 +49,7 @@ public void postProcessEnvironment(ConfigurableEnvironment environment,
 			return;
 		}
 
-		final StandardPodUtils podUtils = new StandardPodUtils(
-				new DefaultKubernetesClient());
-		if (podUtils.isInsideKubernetes()) {
+		if (isInsideKubernetes()) {
 			if (hasKubernetesProfile(environment)) {
 				if (LOG.isDebugEnabled()) {
 					LOG.debug("'kubernetes' already in list of active profiles");
@@ -72,6 +70,13 @@ public void postProcessEnvironment(ConfigurableEnvironment environment,
 		}
 	}
 
+	private boolean isInsideKubernetes() {
+		try (DefaultKubernetesClient client = new DefaultKubernetesClient()) {
+			final StandardPodUtils podUtils = new StandardPodUtils(client);
+			return podUtils.isInsideKubernetes();
+		}
+	}
+
 	private boolean hasKubernetesProfile(Environment environment) {
 		for (String activeProfile : environment.getActiveProfiles()) {
 			if (KUBERNETES_PROFILE.equalsIgnoreCase(activeProfile)) {