Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ribbon should allow discovery across all namespaces #505

Closed
piomin opened this issue Dec 20, 2019 · 1 comment
Closed

Ribbon should allow discovery across all namespaces #505

piomin opened this issue Dec 20, 2019 · 1 comment

Comments

@piomin
Copy link
Contributor

piomin commented Dec 20, 2019

Is your feature request related to a problem? Please describe.
Ribbon should allow discovery across all namespaces. Currently it search for serivces only in the current namespace.

Describe the solution you'd like
Ribbon auto-configuration needs to be changed. and property allNamespaces should be add with default value false

Describe alternatives you've considered
We could also base on existing property spring.cloud.kubernetes.discovery.all-namespaces

@piomin
Copy link
Contributor Author

piomin commented Dec 23, 2019

I decided to add new property for enabling it: spring.cloud.kubernetes.ribbon.allNamespaces - following current approach in Spring Cloud Kubernetes module.
Because Kubernetes allows the same app name in different namespaces I'm checking if there more than one serviceId returned by KubernetesClient in the list endpoints from all namespaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants