Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ConfigurationChangeDetector to simplify conditionals #643

Closed
krisiye opened this issue Sep 24, 2020 · 0 comments · Fixed by #644
Closed

Refactor ConfigurationChangeDetector to simplify conditionals #643

krisiye opened this issue Sep 24, 2020 · 0 comments · Fixed by #644
Labels
enhancement
Projects
2020.0.0-M4
Milestone
2.0.0-M4

Comments

@krisiye
Copy link
Contributor

krisiye commented Sep 24, 2020

As part of #635 we fixed ConfigurationChangeDetector to honor conditionals where either config or secret could be enabled/disabled or vice-versa. This adds a level of complexity and null checking that could be improved upon. Refactor so that we register a ConfigurationChangeDetector each for config/secret and per mode (Polling/Event). Simplify code and more readable.
krisiye added a commit to krisiye/spring-cloud-kubernetes that referenced this issue Sep 26, 2020
@krisiye
Refactor configuration change detector into configMap and Secret chan…
a395699 
…ge detectors each for reload detection mode event/polling. Fixes spring-cloud#643
@krisiye krisiye mentioned this issue Sep 26, 2020
Merged
@ryanjbaxter ryanjbaxter added this to To do in 2020.0.0-M4 via automation Sep 29, 2020
@ryanjbaxter ryanjbaxter added this to the 2.0.0-M4 milestone Sep 29, 2020
2020.0.0-M4 automation moved this from To do to Done Oct 1, 2020
ryanjbaxter pushed a commit that referenced this issue Oct 1, 2020
@krisiye
Refactor ConfigurationChangeDetector to simplify conditionals. Issue …
a4ad5eb 
…643 (#644)

* Refactor configuration change detector into configMap and Secret change detectors each for reload detection mode event/polling. Fixes #643

* Add additional tests

* Refactor spring-cloud-kubernetes-configuration-watcher to decouple configMap and Secrets for HTTP and Bus implementations

* fix logger

* fix checkstyle errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
No open projects
2020.0.0-M4
  
Done
Milestone
2.0.0-M4
3 participants
@ryanjbaxter @krisiye @spring-projects-issues