Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Informer Based Discovery Client Should Default To Current Namespace #678

Closed
ryanjbaxter opened this issue Dec 2, 2020 · 3 comments · Fixed by #747
Closed

Informer Based Discovery Client Should Default To Current Namespace #678

ryanjbaxter opened this issue Dec 2, 2020 · 3 comments · Fixed by #747
Assignees
@ryanjbaxter
Labels
bug
Projects
2020.0.3
Milestone
2.0.3

Comments

@ryanjbaxter
Copy link
Contributor

Currently the informer based discovery client needs cluster wider permissions. This is due to a limitation in the Kubernetes Java Client.

See kubernetes-client/java#1409

We will need to update the Kubernetes Java Client version and revert these changes
40cef54#diff-4a16634dd21836d945914f0b1c0a5ce44df4246dd23394a19d1801e3c7350b53L12
@ryanjbaxter ryanjbaxter added the bug label Dec 2, 2020
@ryanjbaxter ryanjbaxter added this to the 2.0.0-RC1 milestone Dec 2, 2020
@ryanjbaxter ryanjbaxter added this to To do in 2020.0.0-RC1 via automation Dec 2, 2020
@ryanjbaxter ryanjbaxter self-assigned this Dec 2, 2020
@ryanjbaxter ryanjbaxter mentioned this issue Dec 2, 2020
Merged
@yue9944882
Copy link
Contributor

thanks!

@ryanjbaxter ryanjbaxter removed this from To do in 2020.0.0-RC1 Dec 14, 2020
@ryanjbaxter ryanjbaxter added this to To do in 2020.0.0 via automation Dec 14, 2020
@ryanjbaxter
Copy link
Contributor Author

@yue9944882 could we get a new release of the Kubernetes Java Client so we can include this in the upcoming 2020.0.0 release?

@yue9944882
Copy link
Contributor

@ryanjbaxter sure, hopefully we will be seeing a new release this week i think kubernetes-client/java#1441

@spencergibb spencergibb removed this from the 2.0.0-RC1 milestone Dec 22, 2020
@spencergibb spencergibb removed this from To do in 2020.0.0 Dec 22, 2020
@spencergibb spencergibb added this to To do in 2020.0.1 via automation Dec 22, 2020
@spencergibb spencergibb removed this from To do in 2020.0.1 Jan 28, 2021
@spencergibb spencergibb added this to To do in 2020.0.2 via automation Jan 28, 2021
ryanjbaxter added a commit to ryanjbaxter/spring-cloud-kubernetes that referenced this issue Feb 25, 2021
@ryanjbaxter
Scoping informers to specific namespaces to remove cluster scope requ…
8fe0071 
…irement from service account. Fixes spring-cloud#678
@ryanjbaxter ryanjbaxter mentioned this issue Feb 25, 2021
Merged
@spencergibb spencergibb added this to To do in 2020.0.x via automation Mar 18, 2021
@spencergibb spencergibb removed this from To do in 2020.0.2 Mar 18, 2021
2020.0.x automation moved this from To do to Done May 18, 2021
@ryanjbaxter ryanjbaxter removed this from Done in 2020.0.x May 18, 2021
@ryanjbaxter ryanjbaxter added this to To do in 2020.0.3 via automation May 18, 2021
@ryanjbaxter ryanjbaxter added this to the 2.0.3 milestone May 18, 2021
@spencergibb spencergibb moved this from To do to Done in 2020.0.3 May 21, 2021
@ryanjbaxter ryanjbaxter mentioned this issue Jun 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanjbaxter ryanjbaxter

Labels
bug
Projects
No open projects
2020.0.3
  
Done
Milestone
2.0.3
Development

Successfully merging a pull request may close this issue.

Remove clusterrole requirement ryanjbaxter/spring-cloud-kubernetes
3 participants
@ryanjbaxter @spencergibb @yue9944882