Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabric8 it part 4 #1469

Merged
merged 25 commits into from
Oct 6, 2023
Merged

Fabric8 it part 4 #1469

merged 25 commits into from
Oct 6, 2023

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Oct 6, 2023

No description provided.

@wind57
Copy link
Contributor Author

wind57 commented Oct 6, 2023

this one should be easy (and joyful to look at): simply drop an integration test. It's logic is already done in other tests, no need for it.

@wind57 wind57 marked this pull request as ready for review October 6, 2023 20:52
@wind57
Copy link
Contributor Author

wind57 commented Oct 6, 2023

@ryanjbaxter one more ready, but main has failed the built - only because on a certain stage we require to build the docker images and it was so slow that it eventually died. 3.0.x passed on the other hand, imho: this is safe to go on top of main

@ryanjbaxter ryanjbaxter added this to the 3.0.6 milestone Oct 6, 2023
@ryanjbaxter ryanjbaxter merged commit 009c84c into spring-cloud:3.0.x Oct 6, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
3.0.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wind57 @ryanjbaxter @spring-cloud-issues