Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric8 it part 9 #1476

Merged
merged 58 commits into from
Oct 12, 2023
Merged

Fabric8 it part 9 #1476

merged 58 commits into from
Oct 12, 2023

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Oct 8, 2023

No description provided.

@wind57
Copy link
Contributor Author

wind57 commented Oct 8, 2023

same idea as in the previous PR:

spring-cloud-kubernetes-k8s-client-discovery

and

spring-cloud-kubernetes-fabric8-client-discovery

@@ -62,6 +64,5 @@
<module>spring-cloud-kubernetes-client-event-and-polling-reload</module>
<module>spring-cloud-kubernetes-client-configmap-event-reload-multiple-apps</module>
<module>spring-cloud-kubernetes-client-secrets-event-reload-multiple-apps</module>
<module>spring-cloud-kubernetes-client-discovery-it</module>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not deleted, but renamed and moved closer to the fabric8 counterpart.

@wind57 wind57 marked this pull request as ready for review October 12, 2023 07:12
@wind57
Copy link
Contributor Author

wind57 commented Oct 12, 2023

@ryanjbaxter ready to be looked at. I left a single comment because this one just aligns things, as the exact previous PR, so I did not think more would be required. Let me know if you think otherwise, thank you!

@ryanjbaxter ryanjbaxter added this to the 3.0.6 milestone Oct 12, 2023
@ryanjbaxter ryanjbaxter merged commit cfec390 into spring-cloud:3.0.x Oct 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants