Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change directory of failsafe and surefire reports when not using GitHub Actions #1478

Merged

Conversation

ryanjbaxter
Copy link
Contributor

No description provided.

@ryanjbaxter
Copy link
Contributor Author

@wind57 can you please take a look at this? The directory change of surefire and failsafe reports was causing issues for us on Jenkins

@ryanjbaxter ryanjbaxter added this to the 3.0.6 milestone Oct 12, 2023
@ryanjbaxter ryanjbaxter merged commit fe8fa86 into spring-cloud:3.0.x Oct 12, 2023
15 checks passed
@wind57
Copy link
Contributor

wind57 commented Oct 12, 2023

I am more then OK with this change, I just miss where the problem was on jenkins. Not that I am super interested :) but would be nice to know. thank you for tagging me

@ryanjbaxter
Copy link
Contributor Author

We have an assumption across all spring cloud projects that the surefire xml files are in /surefire and changing that assumption for just one project is more work than it is worth

@wind57
Copy link
Contributor

wind57 commented Oct 12, 2023

indeed. thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants