Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Eureka 1.6.0 #1345

Closed
spencergibb opened this issue Sep 15, 2016 · 13 comments
Closed

Upgrade to Eureka 1.6.0 #1345

spencergibb opened this issue Sep 15, 2016 · 13 comments
Milestone

Comments

@spencergibb spencergibb changed the title Upgrade to Eureka 1.5.1 Upgrade to Eureka 1.5.6 Oct 3, 2016
@voor
Copy link

voor commented Oct 26, 2016

@spencergibb Any chance on upgrading to 1.6 to resolve Netflix/eureka#600

@dziadeusz
Copy link

Yes, 1.6 upgrade is critical for jersey based projects

@MaiGhoneim
Copy link

MaiGhoneim commented Oct 30, 2016

latest application servers , weblogic v12.2.1 and Websphere V9.0 both removed JAX-RS1.1 support
Spring cloud netflix deployments to both servers fails.

upgrade to 1.6 is strongly needed.

@adoura
Copy link

adoura commented Nov 3, 2016

@spencergibb : spencer kindly tell us your opinion about this ?

@ryanjbaxter
Copy link
Contributor

I dont see why we couldnt go to 1.6

@spencergibb spencergibb changed the title Upgrade to Eureka 1.5.6 Upgrade to Eureka 1.6.0 Nov 3, 2016
@spencergibb
Copy link
Member Author

Since this is targeted for Dalston, I'm ok with it. Also, just upgrading to 1.6.0 won't automatically mean that jersey 2 is supported. There is work that needs to be done.

spencergibb added a commit that referenced this issue Nov 5, 2016
@adoura
Copy link

adoura commented Nov 5, 2016

@spencergibb : question please , Dalstone will be compatible with spring boot 1.4.1 or it targeting 1.5 ?

@spencergibb
Copy link
Member Author

Dalston will be compatible with 1.4.x and 1.5.x

@ErikLundJensen
Copy link

While testing this I do not see how I tell DiscoveryClient to Jersey 2. The DiscoveryClient constructors taking DiscoveryClientOptionalArgs are deprecated.

I get this error:

Caused by: java.lang.NoClassDefFoundError: com/sun/jersey/api/client/Client
at com.netflix.discovery.shared.transport.jersey.Jersey1TransportClientFactories.newTransportClientFactory(Jersey1TransportClientFactories.java:48)
at com.netflix.discovery.DiscoveryClient.scheduleServerEndpointTask(DiscoveryClient.java:454)
at com.netflix.discovery.DiscoveryClient.(DiscoveryClient.java:392)
... 51 common frames omitted
Caused by: java.lang.ClassNotFoundException: com.sun.jersey.api.client.Client
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)

I have excluded Jersey 1.x as the project already included Jersey 2. Excludes:
jsr311-api
jersey-core
jersey-client
jersey-apache-client4

Does Eureka have a property where I can set the client?

@spencergibb
Copy link
Member Author

Also, just upgrading to 1.6.0 won't automatically mean that jersey 2 is supported. There is work that needs to be done.

@adoura
Copy link

adoura commented Nov 14, 2016

@spencergibb : by work needs to be done you mean dependencies management our side like what @ErikLundJensen was trying to do or what ?

@spencergibb
Copy link
Member Author

@adoura Unknown. I just know that without doing some work on our side, it will not work. Follow #846 for updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants