-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health indicator for Hystrix #24
Comments
Very nice idea. Thanks for creating this. |
I would not recommend using out of service if circuit breakers are open. That is the point of Hystrix that the service does not go out of service. |
Also there are already a bunch of metrics (in /metrics) from Hystrix, so if anyone wants to create a health indicator from them it should be easy (as long as per Spencer's comment) the status is UP by default when the circuit is open. |
@spencergibb if the circuit is open, doesn't that mean the backend service is OUT_OF_SERVICE? That shouldn't indicate the caller is OUT_OF_SERVICE. Therefore setting the entry for the backend service to OUT_OF_SERVICE in the result of the HealthIndicator would be fine, wouldn't it? |
To illustrate: A -> Hystrix -> B Now if the Hystrix circuit to B is open the result of a call to
or instead of using |
That makes sense. It's just the caller (the aggregate status) that should remain "UP". |
There are some crossed wires here as well though. Hystrix itself is not aware of services (that's Ribbon, which confusingly has its own circuit breaker, and publishes metrics to gauge.servo.ZoneStats_CircuitBreakerTrippedCount |
This is now available in d715ec5. |
documentation was not conform to specified behavior as in spring-cloud#24
The health of the Hystrix breakers should be reported as part of the health actuator; see http://java.dzone.com/articles/hystrix-and-spring-boots for an example.
The text was updated successfully, but these errors were encountered: