Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override getThreadPool from HystrixConcurrencyStrategy and delegate to #2044

Conversation

miensol
Copy link
Contributor

@miensol miensol commented Jun 14, 2017

existing strategy if present. Fixes #2035

@pivotal-issuemaster
Copy link

@miensol Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@ryanjbaxter
Copy link
Contributor

Awesome, thanks for this!

You will need to sign the CLA before we can accept the PR.

And if it wouldnt be too much trouble could I ask that you submit the PR against the 1.3.x branch? That way I can merge it forward into master and 2.0.x?

@miensol miensol changed the base branch from master to 1.3.x June 14, 2017 16:32
@pivotal-issuemaster
Copy link

@miensol Thank you for signing the Contributor License Agreement!

@codecov-io
Copy link

codecov-io commented Jun 14, 2017

Codecov Report

Merging #2044 into 1.3.x will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            1.3.x    #2044      +/-   ##
==========================================
+ Coverage   76.26%   76.29%   +0.02%     
==========================================
  Files         209      209              
  Lines        6392     6395       +3     
  Branches      801      801              
==========================================
+ Hits         4875     4879       +4     
+ Misses       1176     1174       -2     
- Partials      341      342       +1
Impacted Files Coverage Δ
...x/security/SecurityContextConcurrencyStrategy.java 77.77% <100%> (-2.23%) ⬇️
...a/server/EurekaServerInitializerConfiguration.java 79.31% <0%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac7799...779b026. Read the comment docs.

@miensol miensol changed the base branch from 1.3.x to master June 14, 2017 16:39
@ryanjbaxter ryanjbaxter changed the base branch from master to 1.3.x June 14, 2017 20:52
@ryanjbaxter ryanjbaxter changed the base branch from 1.3.x to master June 14, 2017 20:52
@ryanjbaxter
Copy link
Contributor

Hum you might have to resubmit the PR to the 1.3.x branch, it still wants to merge to master.

@miensol miensol force-pushed the override_all_hystrix_concurrency_strategy_methods branch from 7d4786d to 779b026 Compare June 15, 2017 04:07
@miensol miensol changed the base branch from master to 1.3.x June 15, 2017 04:24
@miensol
Copy link
Contributor Author

miensol commented Jun 16, 2017

I think I got it now. Does it look good?

@ryanjbaxter ryanjbaxter merged commit 9a878b0 into spring-cloud:1.3.x Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants