Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get health from composite indicators #4074

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

OlgaMaciaszek
Copy link
Collaborator

Fixes gh-4072.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #4074 (c0b709a) into 3.1.x (c350c88) will increase coverage by 0.57%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              3.1.x    #4074      +/-   ##
============================================
+ Coverage     55.26%   55.83%   +0.57%     
- Complexity      511      521      +10     
============================================
  Files            57       57              
  Lines          2470     2477       +7     
  Branches        226      231       +5     
============================================
+ Hits           1365     1383      +18     
+ Misses         1019     1006      -13     
- Partials         86       88       +2     
Impacted Files Coverage Δ
...cloud/netflix/eureka/EurekaHealthCheckHandler.java 91.04% <90.00%> (+12.71%) ⬆️
...rk/cloud/netflix/eureka/EurekaDiscoveryClient.java 34.78% <0.00%> (+17.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c350c88...c0b709a. Read the comment docs.

@spencergibb
Copy link
Member

New tests?

@OlgaMaciaszek
Copy link
Collaborator Author

Merging since all the review suggestions have been addressed.

@OlgaMaciaszek OlgaMaciaszek merged commit 1efa843 into 3.1.x Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netflix Eureka Client Health Check Handler not sending correct status back to Netflix Eureka server
2 participants