add customizer for feign builder #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
============================================
+ Coverage 77.63% 77.77% +0.13%
- Complexity 386 389 +3
============================================
Files 51 51
Lines 1525 1534 +9
Branches 221 222 +1
============================================
+ Hits 1184 1193 +9
Misses 246 246
Partials 95 95
|
...openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignBuilderCustomizer.java
Outdated
Show resolved
Hide resolved
...openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java
Outdated
Show resolved
Hide resolved
spencergibb
requested changes
Jan 31, 2020
...openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java
Outdated
Show resolved
Hide resolved
...openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java
Outdated
Show resolved
Hide resolved
...openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java
Outdated
Show resolved
Hide resolved
IlyasYOY
reviewed
Feb 10, 2020
...nfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientsConfiguration.java
Outdated
Show resolved
Hide resolved
OlgaMaciaszek
approved these changes
Apr 15, 2020
OlgaMaciaszek
added
enhancement
|
Fixes gh-244. |
OlgaMaciaszek
pushed a commit
that referenced
this pull request
Nov 30, 2020
Fixes gh-436. * add customizer for feign builder * support @order for customizers * switch to annotation aware comparator for @order support * remove intermediate instances * removed default feign builder customizer # Conflicts: # spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
CustomizerforFeign.Builderto allow customization.When used
FeignBuilderCustomizerwill override other configurations.Effects
@FeignClientandFeignClientBuilderbuilding.fixes gh-244