New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize load balanced requests according to the chosen ServiceInstance #735
Customize load balanced requests according to the chosen ServiceInstance #735
Conversation
Applications can define their own LoadBalancerFeignRequestTransformer beans which can modify the Request to be executed. These beans can be @ordered in case of multiple transformers.
@galaxy-sea Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@galaxy-sea Thank you for signing the Contributor License Agreement! |
@OlgaMaciaszek |
Hello, @galaxy-sea Thanks for submitting. Will review this week. |
Codecov Report
@@ Coverage Diff @@
## main #735 +/- ##
============================================
- Coverage 79.30% 78.47% -0.84%
- Complexity 546 549 +3
============================================
Files 66 66
Lines 2015 2044 +29
Branches 277 281 +4
============================================
+ Hits 1598 1604 +6
- Misses 261 282 +21
- Partials 156 158 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the PR @galaxy-sea. In general, LGTM. There's just one javadoc missing - have added a comment, please address. Also, have requested @Buzzardo to review the documentation change.
...va/org/springframework/cloud/openfeign/loadbalancer/LoadBalancerFeignRequestTransformer.java
Show resolved
Hide resolved
Hello @OlgaMaciaszek, I have submitted the Javadoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please edit the javadoc.
...va/org/springframework/cloud/openfeign/loadbalancer/LoadBalancerFeignRequestTransformer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @galaxy-sea. This look good to me now. Once @Buzzardo reviews the doc changes and any necessary fixes are made there, we'll be able to merge it.
hello @Buzzardo , I have re edited spring-cloud-openfeign.adoc. |
Thank you. I approved the changes. |
Thank @OlgaMaciaszek @Buzzardo |
Thanks for the contribution @galaxy-sea |
Applications can define their own LoadBalancerFeignRequestTransformer beans
which can modify the Request to be executed. These beans can be
@ordered in case of multiple transformers.
reference Transform the load-balanced HTTP request