Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize load balanced requests according to the chosen ServiceInstance #735

Conversation

galaxy-sea
Copy link
Contributor

Applications can define their own LoadBalancerFeignRequestTransformer beans
which can modify the Request to be executed. These beans can be
@ordered in case of multiple transformers.

reference Transform the load-balanced HTTP request

Applications can define their own LoadBalancerFeignRequestTransformer beans
which can modify the Request to be executed. These beans can be
@ordered in case of multiple transformers.
@pivotal-cla
Copy link

@galaxy-sea Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@galaxy-sea Thank you for signing the Contributor License Agreement!

@galaxy-sea
Copy link
Contributor Author

@OlgaMaciaszek
Can you check this PR.
I hope this function can be seen in the next release.

@OlgaMaciaszek
Copy link
Collaborator

Hello, @galaxy-sea Thanks for submitting. Will review this week.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #735 (d83326e) into main (e4bdc13) will decrease coverage by 0.83%.
The diff coverage is 76.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #735      +/-   ##
============================================
- Coverage     79.30%   78.47%   -0.84%     
- Complexity      546      549       +3     
============================================
  Files            66       66              
  Lines          2015     2044      +29     
  Branches        277      281       +4     
============================================
+ Hits           1598     1604       +6     
- Misses          261      282      +21     
- Partials        156      158       +2     
Impacted Files Coverage Δ
...alancer/DefaultFeignLoadBalancerConfiguration.java 100.00% <ø> (ø)
.../loadbalancer/FeignBlockingLoadBalancerClient.java 72.72% <73.33%> (-10.20%) ⬇️
...ncer/RetryableFeignBlockingLoadBalancerClient.java 61.81% <75.00%> (-9.77%) ⬇️
...cer/HttpClient5FeignLoadBalancerConfiguration.java 100.00% <100.00%> (ø)
...ncer/HttpClientFeignLoadBalancerConfiguration.java 100.00% <100.00%> (ø)
...balancer/OkHttpFeignLoadBalancerConfiguration.java 100.00% <100.00%> (ø)

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR @galaxy-sea. In general, LGTM. There's just one javadoc missing - have added a comment, please address. Also, have requested @Buzzardo to review the documentation change.

@OlgaMaciaszek OlgaMaciaszek added enhancement New feature or request and removed in progress labels Aug 31, 2022
@OlgaMaciaszek OlgaMaciaszek added this to the 3.1.4 milestone Aug 31, 2022
@galaxy-sea
Copy link
Contributor Author

Hello @OlgaMaciaszek, I have submitted the Javadoc

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the javadoc.

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @galaxy-sea. This look good to me now. Once @Buzzardo reviews the doc changes and any necessary fixes are made there, we'll be able to merge it.

@galaxy-sea
Copy link
Contributor Author

hello @Buzzardo , I have re edited spring-cloud-openfeign.adoc.

@Buzzardo
Copy link

Thank you. I approved the changes.

@OlgaMaciaszek OlgaMaciaszek merged commit 5bddccf into spring-cloud:main Sep 1, 2022
@OlgaMaciaszek OlgaMaciaszek modified the milestones: 3.1.4, 4.0.0-M5 Sep 1, 2022
@galaxy-sea
Copy link
Contributor Author

Thank @OlgaMaciaszek @Buzzardo

@OlgaMaciaszek
Copy link
Collaborator

Thanks for the contribution @galaxy-sea

galaxy-sea added a commit to galaxy-sea/heifer that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants