Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for response interceptor configuration. Fixes gh-802 #804

Merged
merged 1 commit into from Dec 15, 2022

Conversation

doumdoum
Copy link
Contributor

@doumdoum doumdoum commented Dec 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #804 (821b6cd) into main (9354054) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #804      +/-   ##
============================================
- Coverage     74.51%   74.47%   -0.04%     
- Complexity      569      570       +1     
============================================
  Files            67       67              
  Lines          2201     2210       +9     
  Branches        297      300       +3     
============================================
+ Hits           1640     1646       +6     
- Misses          394      395       +1     
- Partials        167      169       +2     
Impacted Files Coverage Δ
...mework/cloud/openfeign/FeignClientFactoryBean.java 74.57% <60.00%> (-0.26%) ⬇️
...amework/cloud/openfeign/FeignClientProperties.java 86.08% <75.00%> (-0.40%) ⬇️

@OlgaMaciaszek
Copy link
Collaborator

Fixes gh-802.

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @doumdoum. Thanks for submitting the PR. LGTM. However, please add your full name with @author tag to the javadocs of the classes that you've edited.

@OlgaMaciaszek OlgaMaciaszek added enhancement New feature or request and removed in progress labels Dec 12, 2022
@OlgaMaciaszek
Copy link
Collaborator

Hello, @doumdoum. Thanks for submitting the PR. LGTM. However, please add your full name with @author tag to the javadocs of the classes that you've edited.

I want to make sure we get this into the release, so I'll just add it based on your GH profile.

@OlgaMaciaszek OlgaMaciaszek merged commit fead135 into spring-cloud:main Dec 15, 2022
@doumdoum
Copy link
Contributor Author

Sorry @OlgaMaciaszek i didn't get your requests.
Many thx for accepting that PR.

@OlgaMaciaszek
Copy link
Collaborator

No problem. Thanks for the contribution @doumdoum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Feign response interceptor configuration
3 participants