Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When shell is executed in non-interactive mode, any exception during shell command execution should return a non-zero exit code #372

Closed
markpollack opened this issue Dec 13, 2017 · 2 comments
Closed

When shell is executed in non-interactive mode, any exception during shell command execution should return a non-zero exit code #372

markpollack opened this issue Dec 13, 2017 · 2 comments
Assignees
@jvalkeal
Milestone
1.0.0.RC1

Comments

@markpollack
Copy link
Contributor

A variation on ExitCodeExceptionMapper maybe useful. Commands can return string values that contain error messages and not a stack trace.
@markpollack markpollack added this to the 1.0.0.RC1 milestone Dec 13, 2017
@sabbyanandan sabbyanandan added the type/technical-debt Techical Dept label Dec 18, 2017
@sabbyanandan sabbyanandan added ready and removed type/technical-debt Techical Dept labels Dec 19, 2017
@jvalkeal
Copy link
Contributor

This turned out to be impossible to implement from our side. It all boils down how shell core handles exceptions and you can't hack into shell core without breaking interactive features. Looks like we need to make shell core aware of more non-interactive features.

@markpollack
Copy link
Contributor Author

Waiting on resolution of spring-projects/spring-shell#189

@sabbyanandan sabbyanandan removed this from the 1.0.0.RC1 milestone Jan 12, 2018
@jvalkeal jvalkeal added this to the 1.0.0.RC1 milestone Jan 15, 2018
jvalkeal added a commit to jvalkeal/spring-cloud-skipper that referenced this issue Jan 15, 2018
@jvalkeal
Change non-interactive commands to exit with code
13ab225 
- Using snapshots from shell.
- Change running concepts according to how it is
  now required to tweak non-interactive commands.
- Silence some logging for errors. In non-interactive
  some stacktraces are still logged, which may be
  good or bad thing.
- Remove unused SkipperShellApplicationRunner
- Fixes spring-cloud#372
@jvalkeal jvalkeal mentioned this issue Jan 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvalkeal jvalkeal

Labels
None yet
Projects
None yet
Milestone
1.0.0.RC1
Development

No branches or pull requests
3 participants
@jvalkeal @markpollack @sabbyanandan