Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TraceReactorAutoConfiguration.HooksRefresher improper queue decoration #2318

Closed
kkondratov opened this issue Oct 5, 2023 · 0 comments
Closed
Labels
Milestone

Comments

@kkondratov
Copy link

kkondratov commented Oct 5, 2023

Describe the bug
TraceReactorConfiguration configures Hooks for reactor based on the spring.sleuth.reactor.instrumentation-type property.

However on RefreshScopeRefreshedEvent the HooksRefresher bean decorates reactor with both DECORATE_QUEUES and DECORATE_ON_EACH when the spring.sleuth.reactor.instrumentation-type is set to DECORATE_QUEUES.
The switch statement is missing a break when the DECORATE_QUEUES is done.

See:

This causes Applications that have DECORATE_QUEUES set and get a RefreshScopeRefreshedEvent to spike in cpu usage due hooks added from both DECORATE_QUEUES and DECORATE_QUEUES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants