Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan to support OpenTracing ? #599

Closed
cmoulliard opened this issue May 30, 2017 · 15 comments
Labels
Milestone

Comments

@cmoulliard
Copy link

@cmoulliard cmoulliard commented May 30, 2017

Spring cloud sleuth actively relies on Zipkin Distributed Tracing project. is there any plan to support also the OpenTracing initiative and by example Uber Jaeger project

http://opentracing.io/
https://github.com/opentracing/opentracing-java
https://github.com/opentracing-contrib/java-spring-web

@devinsba

This comment has been minimized.

Copy link
Contributor

@devinsba devinsba commented May 31, 2017

What do you mean by support OpenTracing? If you mean making a sleuth io.opentracing.Tracer then I have a project I've already started to that end that I plan to contribute to the opentracing-contrib organization

https://github.com/DealerDotCom/sleuth-opentracing

@cmoulliard

This comment has been minimized.

Copy link
Author

@cmoulliard cmoulliard commented Jun 2, 2017

contribute to the opentracing-contrib organization

Excellent news. I will have a look. Thanks

@d-sauer

This comment has been minimized.

Copy link

@d-sauer d-sauer commented Jun 4, 2017

How about https://github.com/opentracing-contrib/java-spring-web ?
Is there some main difference between that one and sleuth-opentracing?

@adriancole

This comment has been minimized.

Copy link
Contributor

@adriancole adriancole commented Jun 5, 2017

@marcingrzejszczak

This comment has been minimized.

Copy link
Contributor

@marcingrzejszczak marcingrzejszczak commented Jun 5, 2017

Sorry for the delay in answering the question. Currently adding support for OpenTracing is not on top of our list of priorities. We want to focus more on use cases that the community needs.

@d-sauer

This comment has been minimized.

Copy link

@d-sauer d-sauer commented Jun 5, 2017

Actually I appreciate that detailed answer.
I was looking which direction to choose, but if there is any indication to support OpenTracing in the future of Sleuth, then I would rather go with Sleuth.

@adriancole

This comment has been minimized.

Copy link
Contributor

@adriancole adriancole commented Jun 5, 2017

@adriancole

This comment has been minimized.

Copy link
Contributor

@adriancole adriancole commented Jun 28, 2017

PS I've been noticing conflation of OpenTracing and Jaeger when you follow threads to where they lead. Jaeger for example, accepts zipkin data albeit through an awkward endpoint like https://jaeger-http-collector.mydomain.xxx/api/traces?format=zipkin.thrift. This is a much smaller scope request. Moreover allowing users to see OpenTracing apis is different than forcing sleuth to use them. When folks ask for OpenTracing, please be specific what you are asking for? Ex whether your aim is to force sleuth to use OpenTracing api v0.30 under the covers, whether you want to be able to use OpenTracing apis (and for what?), or if you are just trying to send data to jaeger or lightstep.

@pavolloffay

This comment has been minimized.

Copy link
Contributor

@pavolloffay pavolloffay commented Jul 3, 2017

It's also important to mention that this is not only about sending data to different systems but also sampling and other implementation differences.

@adriancole

This comment has been minimized.

Copy link
Contributor

@adriancole adriancole commented Jul 4, 2017

@pavolloffay so currently sleuth supports different trace context formats using SpanInjector and SpanExtractor. It also supports read-back of baggage.

OpenTracing defines no sampling api, so we can't interact there. There is a sampling priority flag which sometimes is interpreted as a notification of sampling decision and sometimes as a command to sample. It is very confusing... not sure if you are looking for something jaeger-specific or opentracing with regards to sampling. If jaeger-specific, maybe add to a jaeger-specific issue unless we can always assume jaeger==opentracing?

I'd ask, especially as you have many people working on jaeger, to implement sleuth support using the existing hooks in your org. That way, maintenance stays there especially while both jaeger and opentracing are not stable apis.

@marcingrzejszczak

This comment has been minimized.

Copy link
Contributor

@marcingrzejszczak marcingrzejszczak commented Jul 11, 2017

I'm closing this issue for now due to reasons that @adriancole has mentioned

@pavolloffay

This comment has been minimized.

Copy link
Contributor

@pavolloffay pavolloffay commented Sep 11, 2017

For people who would like to use OpenTracing with spring cloud https://github.com/opentracing-contrib/java-spring-cloud

@sudr

This comment has been minimized.

Copy link

@sudr sudr commented Apr 24, 2018

Apologies for posting this question on a closed thread since I am not sure where else I could post it. I wanted to check whether the Spring Cloud Sleuth tracing output can be consumed by any monitoring application that can understand OpenTracing tracing payloads.

Reason this isn't clear to me is I see the following blurb on the Spring Cloud Sleuth documentation page: "....Spring Cloud Sleuth is OpenTracing compatible.....". But nowhere in the documentation for the Brave tracer (which I understand in used by Spring Cloud Sleuth) does it state that it generates traces in the OpenTracing format. Instead Brave seams to be purpose built for Zipkin.

@spencergibb

This comment has been minimized.

Copy link
Member

@spencergibb spencergibb commented Apr 24, 2018

You're right, questions should go on https://gitter.im/spring-cloud/spring-cloud-sleuth or stack overflow.

@adriancole

This comment has been minimized.

Copy link
Contributor

@adriancole adriancole commented Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.