Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic destinations don't work with a transactional binder #626

Closed
garyrussell opened this issue Apr 3, 2019 · 0 comments
Closed

Dynamic destinations don't work with a transactional binder #626

garyrussell opened this issue Apr 3, 2019 · 0 comments
Assignees
Labels

Comments

@garyrussell
Copy link
Contributor

In createProducerMessageHandler() when creating a producer message handler, the binder creates a temporary producer to get information about the topic.

It then destroys the producer factory to close the (normally) single-shared producer object

However, it should not destroy the factory when the binder is transactional since the producer factory is shared.

See https://stackoverflow.com/questions/55498015/spring-cloud-stream-kafka-consumer-producer-api-exactly-once-semantics-transact

@garyrussell garyrussell added the bug label Apr 3, 2019
sobychacko added a commit to sobychacko/spring-cloud-stream-binder-kafka that referenced this issue Apr 8, 2019
With a transactional binder, the producer factory should not be destroyed.

Resolves spring-cloud#626
@sobychacko sobychacko self-assigned this Apr 8, 2019
garyrussell pushed a commit that referenced this issue Apr 8, 2019
With a transactional binder, the producer factory should not be destroyed.

Resolves #626
@garyrussell garyrussell removed the in pr label Apr 8, 2019
garyrussell pushed a commit that referenced this issue Apr 8, 2019
With a transactional binder, the producer factory should not be destroyed.

Resolves #626
garyrussell pushed a commit that referenced this issue Apr 8, 2019
With a transactional binder, the producer factory should not be destroyed.

Resolves #626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants