GH-935: Fix KafkaNullConverter supported MimeType #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-cloud#935 Spring Cloud Function now checks if a converter supports the mime type before calling it. Previously, the converter supported no mime types, so it was never called, breaking Kafka Tombstone record processing (outbound). The converter must support all mime types so it can perform a no-op conversion, retaining the `KafkaNull`. The abstract converter will return null whenever the payload is not a `KafkaNull`, which is a signal to spring-cloud-function to try the next converter.
|
Addressed in 83c42a5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #935
Spring Cloud Function now checks if a converter supports the mime type before
calling it. Previously, the converter supported no mime types, so it was never
called, breaking Kafka Tombstone record processing (outbound).
The converter must support all mime types so it can perform a no-op conversion,
retaining the
KafkaNull.The abstract converter will return null whenever the payload is not a
KafkaNull,which is a signal to spring-cloud-function to try the next converter.