Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove log noise with publisher confirms #152

Closed
garyrussell opened this issue May 22, 2018 · 0 comments
Closed

Remove log noise with publisher confirms #152

garyrussell opened this issue May 22, 2018 · 0 comments
Assignees
@garyrussell
Milestone
2.1.0.M1

Comments

@garyrussell
Copy link
Contributor

When publisher confirms are enabled, we only bind a nackchannel.

This causes log noise

2018-05-22 11:02:01.212 INFO 11951 --- [ 127.0.0.1:5672] o.s.i.a.outbound.AmqpOutboundEndpoint : Nowhere to send publisher confirm ack for GenericMessage [payload=byte[3], headers={contentType=application/json, id=6e846138-8845-e4f2-96ab-adbe4fddc958, timestamp=1527001321193}]

Since boot logs at INFO by default.

Inject a NullChannel
@garyrussell garyrussell added this to the 2.1.0.M1 milestone May 22, 2018
@garyrussell garyrussell self-assigned this May 22, 2018
garyrussell added a commit to garyrussell/spring-cloud-stream-binder-rabbit that referenced this issue May 22, 2018
@garyrussell
spring-cloudGH-152: Inject nullChannel for confirm acks
1d0dcd3 
Fixes spring-cloud#152

Reduce log noise since we only express interest in nacks.
@garyrussell garyrussell mentioned this issue May 22, 2018
Merged
artembilan pushed a commit that referenced this issue May 23, 2018
@garyrussell @artembilan
GH-152: Inject nullChannel for confirm acks
5a95735 
Fixes #152

Reduce log noise since we only express interest in nacks.
@artembilan artembilan removed the in pr label May 23, 2018
artembilan pushed a commit that referenced this issue May 23, 2018
@garyrussell @artembilan
GH-152: Inject nullChannel for confirm acks
03872e5 
Fixes #152

Reduce log noise since we only express interest in nacks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
None yet
Projects
None yet
Milestone
2.1.0.M1
Development

No branches or pull requests
2 participants
@garyrussell @artembilan