Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ack the original queue message after republishToDlq when consumer using MANUAL ack-mode #281

Closed
JiaRG opened this issue Jan 18, 2020 · 0 comments · Fixed by #282
Closed

Ack the original queue message after republishToDlq when consumer using MANUAL ack-mode #281

JiaRG opened this issue Jan 18, 2020 · 0 comments · Fixed by #282
Assignees
@garyrussell
Milestone
Horsham.SR2

Comments

@JiaRG
Copy link

JiaRG commented Jan 18, 2020

See: https://stackoverflow.com/a/59786082/10915801
@garyrussell garyrussell self-assigned this Jan 18, 2020
garyrussell added a commit to garyrussell/spring-cloud-stream-binder-rabbit that referenced this issue Jan 28, 2020
@garyrussell
spring-cloudGH-281: Republish to DLQ ack original when MANUAL
ff57549 
Resolves spring-cloud#281

When using `AcknowledgeMode.MANUAL` with `republishToDlq`, original message is left
in an un-ack'd state.

Always ack the original message after republishing to the DLQ.
garyrussell added a commit to garyrussell/spring-cloud-stream-binder-rabbit that referenced this issue Jan 28, 2020
@garyrussell
spring-cloudGH-281: Republish to DLQ ack original when MANUAL
065c9b1 
Resolves spring-cloud#281

When using `AcknowledgeMode.MANUAL` with `republishToDlq`, original message is left
in an un-ack'd state.

Always ack the original message after republishing to the DLQ.
@garyrussell garyrussell mentioned this issue Jan 28, 2020
Merged
@sabbyanandan sabbyanandan added this to the Horsham.SR2 milestone Jan 28, 2020
@olegz olegz closed this as completed in #282 Feb 6, 2020
olegz pushed a commit that referenced this issue Feb 6, 2020
@garyrussell @olegz
GH-281: Republish to DLQ ack original when MANUAL
ffbda2e 
Resolves #281

When using `AcknowledgeMode.MANUAL` with `republishToDlq`, original message is left
in an un-ack'd state.

Always ack the original message after republishing to the DLQ.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
None yet
Projects
None yet
Milestone
Horsham.SR2
Development

Successfully merging a pull request may close this issue.

GH-281: Republish to DLQ ack original when MANUAL garyrussell/spring-cloud-stream-binder-rabbit
3 participants
@garyrussell @sabbyanandan @JiaRG