Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Task to accept externally generated task id #115

Closed
mminella opened this issue Apr 1, 2016 · 3 comments
Closed

Enable Task to accept externally generated task id #115

mminella opened this issue Apr 1, 2016 · 3 comments
Assignees
@mminella @cppwfs
Milestone
1.1.0.M2

Comments

@mminella
Copy link
Contributor

mminella commented Apr 1, 2016 •
edited by cppwfs

In order to allow for the time difference between when a task is requested and the infrastructure actually launches it, we'll need to be able to map the infrastructure's execution id with the task execution id. This story is to allow that mapping to occur by having the launcher do the creation of the task execution record within the task repository.
@mminella mminella self-assigned this Apr 1, 2016
@mminella mminella added this to the 1.0.0.M2 milestone Apr 1, 2016
@jvalkeal
Copy link
Contributor

jvalkeal commented Apr 6, 2016

Once spring-cloud/spring-cloud-dataflow#492 is merged we could have a chat about this implementation in more detailed level.

@markfisher
Copy link

spring-cloud/spring-cloud-dataflow#492 is now merged

@jvalkeal
Copy link
Contributor

jvalkeal commented Apr 6, 2016

@mminella so only integration from tasks towards this deployment id repository is TaskDeploymentController.java#L153

Similarly we now have an option to do more clever cancel(undeploy in stream):
StreamDeploymentController.java#L370

And possibly querying status from deployer point of view if task is not yet running(shell status for stream):
StreamDefinitionController.java#L200

I think this thing around execution id becomes more clear if/when we try to implement those cancel()/status() features from tasks side towards TaskLauncher.

@sabbyanandan sabbyanandan modified the milestones: 1.0.0.M2, 1.0.0.RC1 Apr 21, 2016
@sabbyanandan sabbyanandan removed this from the 1.0.0.RC1 milestone Jun 3, 2016
@sabbyanandan sabbyanandan modified the milestone: 1.0.0.RC1 Jun 5, 2016
@sabbyanandan sabbyanandan modified the milestones: 1.1.0.M1, 1.0.0.RC1 Jun 6, 2016
@sabbyanandan sabbyanandan removed the ready label Jul 5, 2016
@sabbyanandan sabbyanandan removed this from the 1.1.0.M1 milestone Sep 7, 2016
@cppwfs cppwfs mentioned this issue Sep 7, 2016
Closed
@sabbyanandan sabbyanandan added this to the 1.1.0.M2 milestone Sep 7, 2016
cppwfs pushed a commit to cppwfs/spring-cloud-task that referenced this issue Sep 15, 2016
Checks for invalid ExecutionId in the TaskLifeCycleListener
829bef0 
resolves spring-cloud#115
* Fixes bug where if the user set the environment variable and commandline args a unique constraint would fire.
* Updated docs
* Removed deprecation
* Fixed version number for integration test.

Added integration tests for externally generated task executions
@cppwfs cppwfs mentioned this issue Sep 15, 2016
Closed
@cppwfs cppwfs added in pr and removed in progress labels Sep 15, 2016
cppwfs pushed a commit to cppwfs/spring-cloud-task that referenced this issue Sep 16, 2016
Checks for invalid ExecutionId in the TaskLifeCycleListener
9477304 
resolves spring-cloud#115
* Fixes bug where if the user set the environment variable and commandline args a unique constraint would fire.
* Updated docs
* Removed deprecation
* Fixed version number for integration test.

Added integration tests for externally generated task executions
cppwfs pushed a commit to cppwfs/spring-cloud-task that referenced this issue Sep 21, 2016
Checks for invalid ExecutionId in the TaskLifeCycleListener
fc54ff3 
resolves spring-cloud#115
* Fixes bug where if the user set the environment variable and commandline args a unique constraint would fire.
* Updated docs
* Removed deprecation
* Fixed version number for integration test.

Added integration tests for externally generated task executions
@mminella mminella removed the in pr label Oct 10, 2016
cppwfs pushed a commit to cppwfs/spring-cloud-task that referenced this issue Oct 11, 2016
@mminella
Checks for invalid ExecutionId in the TaskLifeCycleListener
e4e156f 
resolves spring-cloud#115
* Fixes bug where if the user set the environment variable and commandline args a unique constraint would fire.
* Updated docs
* Removed deprecation
* Fixed version number for integration test.

Added integration tests for externally generated task executions

Add externalExecutionId

resolves spring-cloud#80
mminella added a commit that referenced this issue Oct 12, 2016
@mminella
Checks for invalid ExecutionId in the TaskLifeCycleListener
17e4250 
resolves #115
* Fixes bug where if the user set the environment variable and commandline args a unique constraint would fire.
* Updated docs
* Removed deprecation
* Fixed version number for integration test.

Added integration tests for externally generated task executions

Add externalExecutionId

resolves #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mminella mminella

@cppwfs cppwfs

Labels
None yet
Projects
None yet
Milestone
1.1.0.M2
Development

Successfully merging a pull request may close this issue.

SCT-115 Enable Task to accept externally generated task id cppwfs/spring-cloud-task
5 participants
@jvalkeal @markfisher @mminella @cppwfs @sabbyanandan