Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For updating Spring Boot version #6

Merged
merged 2 commits into from Oct 2, 2023

Conversation

vimalJD
Copy link
Contributor

@vimalJD vimalJD commented Sep 28, 2023

Issue: Update Spring Boot version #5

  • Both pom.xml files have been updated manually with typing, It is not updated via run the project in any IDE.(Please simplify this)
  • But how to run the project, should I convert it into a Maven project? or there is another way to run it?
  • Because without running the application from IDE as Spring tool suite
  • Below Action will not be performed.
use task;
show tables; --show all tables that Spring Cloud Task created
select * from task_execution;

application.properties file

But how to run the project, should i convert into a Maven project? or
there is other way to run it?
@pivotal-cla
Copy link

@vimalJD Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@vimalJD Thank you for signing the Contributor License Agreement!

@vimalJD vimalJD changed the title Update Spring Boot version #5 Update Spring Boot version Sep 28, 2023
@vimalJD vimalJD changed the title Update Spring Boot version For updating Spring Boot version Sep 28, 2023
@robertmcnees
Copy link
Contributor

Thanks for the PR!

Can you exclude the application.properties from this PR? I'd like to leave it commented out so that Docker is not required in the base case and this line remains true.

 excluded the application.properties from this pr and `spring.datasource` properties in `application.properites` are commented out
@vimalJD
Copy link
Contributor Author

vimalJD commented Sep 29, 2023

Project has looked as multiple module as pom.xml.

  • So tell me, Do i need to run as converting in maven with parent pom.xml?
  • If it would be to mention the 2 child module pom.xml of complete and initial entry into parent pom.xml.

@vimalJD
Copy link
Contributor Author

vimalJD commented Oct 1, 2023

Does the project need to be run with Maven for the updating Spring boot version?

  • If it must be, Then It is a 2-module project with respective to 2 pom.xml as complete and initial.
  • And there is no parent pom.xml for mentioning the entry of those two modules,
  • So, Should I need to create a parent pom.xml?


@vimalJD vimalJD marked this pull request as draft October 2, 2023 09:42
@vimalJD vimalJD marked this pull request as ready for review October 2, 2023 09:43
@robertmcnees robertmcnees merged commit 1314777 into spring-guides:main Oct 2, 2023
2 checks passed
@robertmcnees
Copy link
Contributor

Hi @vimalJD . Thanks for the PR! Looks good.

Regarding the project structure, the initial and complete folders are intended to be separate projects. There is no need for a parent pom.xml in this case.

You are correct that MariaDB, changes in application.properties, and Docker are required to perform the last step of the guide. However the guide can also build with H2 for the fastest getting started experience. This can work without any datasource defined.

Spring Cloud Task using In Memory H2
For the first step, we use Spring Cloud Task with an embedded H2 datastore. If no spring.datasource properties are detected on project initialization, Spring Cloud Task spins up a new H2 instance to store the executed task results. This happens without any extra configuration. This facilitates a quick way to get up and running, but the results of your executed task are lost when the application completes and the H2 database shuts down. For this step in the guide, ensure that the spring.datasource properties in application.properites are commented out.

@vimalJD
Copy link
Contributor Author

vimalJD commented Oct 2, 2023

Glad to connect with you, Having learned from this open source contribution with my favourite programming language as a java using spring boot for merging my pull request. Meanwhile, learnt how docker could communicate with database using tools such as git bash command as well as WSL2 with linux distros - Ubuntu. and again thanks for this explaination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants