Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reactive Security #460

Closed
rwinch opened this issue Jul 13, 2017 · 7 comments
Closed

Add Reactive Security #460

rwinch opened this issue Jul 13, 2017 · 7 comments
Assignees

Comments

@rwinch
Copy link

rwinch commented Jul 13, 2017

Please add a reactive security option

cc @joshlong

@snicoll
Copy link
Contributor

snicoll commented Jul 13, 2017

Please expand what that means.

@rwinch
Copy link
Author

rwinch commented Jul 13, 2017

The equivalent of the Security but for Reactive.

@snicoll
Copy link
Contributor

snicoll commented Jul 14, 2017

We will, of course, add a Reactive Security option to Initialzr but there are a few things that need to happen first:

  1. Spring Boot needs to be using a version of Spring Security with Reactive Support
  2. Spring Boot needs to have auto-configuration for Reactive Security
  3. Spring Boot needs to provide a Reactive Security starter

I am not 100% sure about 3 yet but regardless I don't see this request happening before proper support land in Spring Boot. Have I missed something?

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Jul 14, 2017
@rwinch
Copy link
Author

rwinch commented Jul 14, 2017

Thanks. I think it makes sense to wait for this list to be taken care of.

Spring Security 5.0.0.M1+ includes reactive support so this should be taken care of.

I believe that the second one will be addressed in Spring Boot M4 which is when we are planning for addressing Spring Security Auto configuration.

I'm not sure what Boot will do in terms of starters for Reactive Security either.

@sdeleuze
Copy link
Contributor

Another important point IMO : Spring Security should support the functional web API as well. We do our best to mutualize infrastrcture between annotation and functional variants, so there is maybe not much to do, but worth to check since Boot supports both.

@rwinch
Copy link
Author

rwinch commented Jul 15, 2017

We do support it through the same setup as annotated framework. See https://github.com/spring-projects/spring-security/tree/master/samples/javaconfig/hellowebfluxfn/src/main/java/sample

Given the amount of effort due to lack of overlap in the APIs and the fact that Functional API does not support global filtering I'm not sure we will ever support registration through the route API.

@snicoll snicoll added status: on-hold and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 15, 2017
@snicoll
Copy link
Contributor

snicoll commented Sep 15, 2017

@snicoll snicoll self-assigned this Oct 1, 2017
@snicoll snicoll closed this as completed in bf2a991 Oct 1, 2017
sayeedap pushed a commit to sayeedap/initializr that referenced this issue Sep 16, 2022
fixed circular dependency issue on python generated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants