Add jackson-module-kotlin dependency when relevant
#600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snicoll
requested changes
Feb 12, 2018
| any other dependency with that facet is included. The value of the "facets" property of a | ||
| dependency is a list of strings. | ||
| generated project. In the standard Initializr generator, there are only two facets that | ||
| are actually used (`web` and `json`), but custom installations might choose to use it for |
There was a problem hiding this comment.
I wouldn't update the documentation of the library for a service-specific feature.
This commit introduces a "json" facet designed to identify spring-boot-starter-json transitive dependency, and adds jackson-module-kotlin dependency if any dependency with that facet is included when Kotlin language is used.
sdeleuze
force-pushed
the
jackson-kotlin
branch
from
eec45a5
to
28c52e4
Compare
|
Done |
snicoll
approved these changes
Feb 12, 2018
snicoll
pushed a commit
that referenced
this pull request
Feb 12, 2018
This commit introduces a "json" facet designed to identify spring-boot-starter-json transitive dependency, and adds jackson-module-kotlin dependency if any dependency with that facet is included when Kotlin language is used. See gh-600
snicoll
added a commit
that referenced
this pull request
Feb 12, 2018
* pr/600: Polish "Add jackson-module-kotlin dependency when appropriate" Add jackson-module-kotlin dependency when appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a "json" facet designed to identify
spring-boot-starter-jsontransitive dependency, and addsjackson-module-kotlindependency if any dependency with that facet is included when Kotlin language is used.