This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
Upgrade rometools to 1.7.1 #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artembilan @garyrussell I have a recollection of one of you saying that there was a problem with a particular version of Rome Tools. I see you're using 1.7.0 in SI 5 at the moment so I assume that version's ok. Did you have a problem with 1.7.1 or am I imagining things? |
|
Hi @wilkinsona I don't remember the discussion and haven't found anything in email threads since we moved to 1.5, some 2+ years ago. I just tested SI with 1.7.1 on master (Cairo) with no problems. Note that SI 4.3 still uses 1.6.0 - I see that IO has 1.6.1. We should update both SI branches to 1.x.1. |
wilkinsona
added a commit
that referenced
this pull request
Feb 2, 2017
* gh-496: Upgrade to Rome Tools 1.7.1
|
Thanks, @garyrussell. @stonio Thanks for the PR, I've merged it into master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See previous upgrade #340