-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add paging support for Github requests #764
Conversation
1bbbd0a
to
c140c8e
Compare
@bclozel I rebased this PR against latest master. Also, I tried to configure Eclipse Code Formatter, but it still won't apply imports in the proper order. |
@@ -17,6 +18,11 @@ | |||
return operations.getForObject(url, clazz); | |||
} | |||
|
|||
@Cacheable(value = CACHE_NAME, key = "#url") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work since we're already using that key to cache objects of types T
. So fetching from the cache using an URL, you can get the wrong thing depending on the method.
Also, ResponseEntity
is not serializable and that won't work with the default JDK serializer used by the redis cache manager. See CacheConfig
for the configuration used for other types.
I should review the current caching infrastructure because this is not making it easier to leverage more caching.
|
Digging further in, I actually need the |
@bclozel Friendly ping. |
74e9f25
to
7bf1435
Compare
This part has been moved to sagan-renderer and supports now paging for requests to GitHub. |
No description provided.