Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dependency on spring-restdocs-webtestclient rather than spring-restdocs-mockmvc when using WebFlux or Jersey #55

Closed
jnizet opened this issue Feb 18, 2019 · 2 comments
Closed

Add a dependency on spring-restdocs-webtestclient rather than spring-restdocs-mockmvc when using WebFlux or Jersey #55

jnizet opened this issue Feb 18, 2019 · 2 comments
Assignees
@wilkinsona
Labels
type: enhancement

Comments

@jnizet
Copy link

jnizet commented Feb 18, 2019 •
edited by snicoll
Loading

When creating a project with webflux and restdocs, I expect a dependency to spring-restdocs-webtestclient to be added to the project. But instead, a dependency to spring-restdocs-mockmvc is added.
@snicoll snicoll transferred this issue from spring-io/initializr Feb 18, 2019
@snicoll
Copy link
Contributor

snicoll commented Feb 18, 2019

paging @wilkinsona

@wilkinsona
Copy link
Contributor

I agree with the suggestion. It make sense to flip the spring-restdocs-mockmvc dependency to a dependency on spring-restdocs-webtestclient when the WebFlux starter is being used.

@wilkinsona wilkinsona changed the title Wrong dependency when selecting webflux and restdocs Add a dependency on spring-restdocs-webtestclient rather than spring-restdocs-mockmvc when using WebFlux or Jersey Feb 19, 2019
@wilkinsona wilkinsona self-assigned this Feb 19, 2019
davsclaus pushed a commit to davsclaus/start.spring.io that referenced this issue May 15, 2019
@wilkinsona @davsclaus
Switch to spring-restdocs-webtestclient when using Jersey or WebFlux
9fda9b3 
Closes spring-iogh-55
davsclaus pushed a commit to davsclaus/start.spring.io that referenced this issue Nov 1, 2019
@wilkinsona @davsclaus
Switch to spring-restdocs-webtestclient when using Jersey or WebFlux
a0c5a45 
Closes spring-iogh-55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snicoll @wilkinsona @jnizet