Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Apache Camel 3 #347

Closed
wants to merge 3 commits into from
Closed

Conversation

davsclaus
Copy link
Contributor

Beware I was not able to test this locally as I get some error about missing fonts.

[INFO]  ERROR #11321  PLUGIN
[INFO]
[INFO] "gatsby-plugin-prefetch-google-fonts" threw an error while running the onPreBootstrap lifecycle:
[INFO]
[INFO] ENOENT: no such file or directory, stat '.cache/google-fonts//fonts'
[INFO]

[INFO]
[INFO]   Error: ENOENT: no such file or directory, stat '.cache/google-fonts//fonts'
[INFO]
[INFO] ⠹ onPreBootstrap
[ERROR] error Command failed with exit code 1.
[INFO] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

So maybe you guys can check this.

In Apache Camel v3 we have changed the groupId for our spring boot starters, from org.apache.camel to org.apache.camel.springboot. Therefore I created a new camel3 entry in the yaml file. Not sure if this is the correct way if we want to have support for older Camel 2.x on earlier Spring Boot versions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 6, 2019
@snicoll
Copy link
Contributor

snicoll commented Dec 6, 2019

Thanks for the PR. We are aware of the font issue and are investigating it.

Copy link
Contributor

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. There are a number of problems with it.

Is there a place where I can read more about the groupId change in Camel 3?

version: 2.24.2
description: Apache Camel lets you create the Enterprise Integration Patterns to implement routing and mediation rules a Java based Domain Specific Language via Spring.
description: Apache Camel is the Swiss knife of integration.
Copy link
Contributor

@snicoll snicoll Dec 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this. I am happy to discuss how to update the description but this shouldn't be part of a dependency upgrade.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so I can open another PR with just description change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we'll change the description to what you've suggested but that discussion should happen independently. Either a dedicated PR or an issue is fine, thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well surely the 3rd party project maintainers should influence what the description is for their project

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't shut it down, did I? Of course, any suggestion to improve the description of an entry is much welcome.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thanks as the one that is currently is a very old description that is out of date and a bit confusing.

How about using what's on the main website

Camel is an open source integration framework that empowers you to quickly and easily integrate various systems consuming or producing data.

https://camel.apache.org/

- rel: guide
- rel: reference
href: https://camel.apache.org/spring-boot
- name: Apache Camel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't have two separate entries for the same artifact. If the artifactId has changed, you can define that as part of the mapping entry (i.e. at the same level you map the version, you can also specify a different groupId).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay so maybe we can just specify the new groupId instead

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue type: entry-upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 7, 2019
@davsclaus
Copy link
Contributor Author

Thanks @snicoll I did some updates, let me know if we are getting closer. The PR can be cleaned up later, or you are surely welcome to squash and put a nice git commit message.

@davsclaus
Copy link
Contributor Author

@snicoll
Copy link
Contributor

snicoll commented Dec 7, 2019

Thanks @davsclaus. I had a look to that link. Unfortunately that doesn't explain why the starter was relocated in a different groupId. Is there some more information about that?

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 7, 2019
@davsclaus
Copy link
Contributor Author

Thanks @davsclaus. I had a look to that link. Unfortunately that doesn't explain why the starter was relocated in a different groupId. Is there some more information about that?

Its because Apache Camel v3 are having modules separated more. Its been discussed on the JIRA and Camel mailing lists.

https://issues.apache.org/jira/browse/CAMEL-13643
https://camel.465427.n5.nabble.com/DISCUSS-Changing-the-Maven-group-ID-for-Spring-Boot-starters-td5836268.html

snicoll pushed a commit that referenced this pull request Dec 7, 2019
snicoll added a commit that referenced this pull request Dec 7, 2019
@snicoll snicoll closed this in c2c2b00 Dec 7, 2019
@snicoll snicoll removed the status: feedback-provided Feedback has been provided label Dec 7, 2019
@snicoll snicoll self-assigned this Dec 7, 2019
@snicoll
Copy link
Contributor

snicoll commented Dec 7, 2019

@davsclaus thanks for the PR, I've polished the proposal so that the mapping is not required going forward, please see 573c1ff.

Feel free to open a PR for additional metadata improvements on the Camel entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants