Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging statements that are always printed even when debug is not… #59

Merged
merged 1 commit into from Jan 28, 2021

Conversation

snorberhuis
Copy link
Contributor

… turned on.

If the router parses an SNS event, the SQS console log statement is printed. It ignores the config setting debug. So every SNS event would have this log statement.

This PR fixes that problem.

Example:
image

@codecov-io
Copy link

Codecov Report

Merging #59 (c4bbcc0) into master (a3de148) will decrease coverage by 0.95%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   89.16%   88.21%   -0.96%     
==========================================
  Files           6        6              
  Lines         277      280       +3     
  Branches       84       87       +3     
==========================================
  Hits          247      247              
- Misses         30       33       +3     
Impacted Files Coverage Δ
lib/s3.ts 88.09% <50.00%> (-2.15%) ⬇️
lib/sns.ts 77.77% <50.00%> (-4.58%) ⬇️
lib/sqs.ts 80.95% <50.00%> (-4.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3de148...c4bbcc0. Read the comment docs.

@chgohlke
Copy link
Member

👍

@chgohlke chgohlke merged commit ea4dff4 into spring-media:master Jan 28, 2021
@snorberhuis snorberhuis deleted the bug/fix-debug-logging branch February 3, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants