Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added kinesis as event source #49

Merged
merged 4 commits into from
Feb 3, 2020
Merged

added kinesis as event source #49

merged 4 commits into from
Feb 3, 2020

Conversation

moritzzimmer
Copy link
Contributor

@moritzzimmer moritzzimmer commented Jan 31, 2020

aws_lambda_event_source_mapping and iam role configuration to support Kinesis record processing (https://docs.aws.amazon.com/lambda/latest/dg/with-kinesis.html)

chgohlke
chgohlke previously approved these changes Jan 31, 2020
Copy link
Member

@chgohlke chgohlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moritzzimmer
Copy link
Contributor Author

moritzzimmer commented Jan 31, 2020

@chgohlke could u merge the PR? I'm (currently) not allowed

@moritzzimmer moritzzimmer added the enhancement New feature or request label Jan 31, 2020
moritzzimmer added a commit to moritzzimmer/func that referenced this pull request Jan 31, 2020
chgohlke
chgohlke previously approved these changes Jan 31, 2020
Copy link
Member

@chgohlke chgohlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same same 👍

@moritzzimmer
Copy link
Contributor Author

please review again @chgohlke

@moritzzimmer moritzzimmer merged commit e189d27 into spring-media:master Feb 3, 2020
@moritzzimmer moritzzimmer deleted the kinesis-stream branch February 3, 2020 12:18
moritzzimmer added a commit to moritzzimmer/func that referenced this pull request Feb 3, 2020
* added support for new kinesis event

we need spring-media/terraform-aws-lambda#49
merged and released as v4.4.0 before

* removed deprecated table name from config map

* added stream name to kinesis blueprint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants