-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added kinesis as event source #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chgohlke
previously approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@chgohlke could u merge the PR? I'm (currently) not allowed |
moritzzimmer
added a commit
to moritzzimmer/func
that referenced
this pull request
Jan 31, 2020
we need spring-media/terraform-aws-lambda#49 merged and released as v4.4.0 before
chgohlke
previously approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same same 👍
see official sam iam templates for the why: https://github.com/awslabs/serverless-application-model/blob/develop/samtranslator/policy_templates_data/policy_templates.json
please review again @chgohlke |
chgohlke
approved these changes
Jan 31, 2020
moritzzimmer
added a commit
to moritzzimmer/func
that referenced
this pull request
Feb 3, 2020
* added support for new kinesis event we need spring-media/terraform-aws-lambda#49 merged and released as v4.4.0 before * removed deprecated table name from config map * added stream name to kinesis blueprint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws_lambda_event_source_mapping and
iam
role configuration to support Kinesis record processing (https://docs.aws.amazon.com/lambda/latest/dg/with-kinesis.html)