Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Dockerfile versions #54

Closed
wants to merge 2 commits into from
Closed

Updated Dockerfile versions #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec2e6df
updated container versions, added --no-package-lock
sdstolworthy Apr 26, 2021
52d3f37
removed --no-package-lock flag, shifted args to top of docker file
sdstolworthy Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
ARG DOCKER_HUB="docker.io"
ARG NGINX_VERSION="1.20.0"
ARG NODE_VERSION="14.16.1-alpine3.13"
ARG NPM_REGISTRY="https://registry.npmjs.org"

FROM $DOCKER_HUB/library/node:10.10-alpine as build
FROM $DOCKER_HUB/library/node:${NODE_VERSION} AS build


COPY . /workspace/

ARG NPM_REGISTRY=" https://registry.npmjs.org"

RUN echo "registry = \"$NPM_REGISTRY\"" > /workspace/.npmrc && \
cd /workspace/ && \
npm install && \
npm run build

ARG NGINX_VERSION="1.17.6"
FROM $DOCKER_HUB/library/nginx:$NGINX_VERSION AS runtime
FROM $DOCKER_HUB/library/nginx:${NGINX_VERSION} AS runtime


COPY --from=build /workspace/dist/ /usr/share/nginx/html/
Expand All @@ -28,5 +28,3 @@ EXPOSE 8080
USER nginx

HEALTHCHECK CMD [ "service", "nginx", "status" ]