-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give unique image name #14
Comments
@odedia what do you think about? |
Not sure I’m following, do you currently have access to this repo on dockerhub? |
Yes, I've created the |
It's not a best practice to deploy images with the latest tag anyway, since it will never actually pull it a second time without forcing a delete and reapply. So it's best to define the deployment yaml with a dynamic tag as well, maybe based on a build number.
… On 8 Nov 2020, at 18:17, Antoine Rey ***@***.***> wrote:
Yes, I've created the springcommunity organization on DockerHub. I've just added you as a member.
If neeeded, we could create another organization on DockerHub, Amazon ECR or whatever.
Your approach to concatenate the maven profile with the version could do the job. I see an issue: the latest tag could reference mix profiles: springcommunity/spring-petclinic-cloud-vets-service:k8sv1 and springcommunity/spring-petclinic-cloud-pets-service:cloudv1 (by the way, do we have to rename the cloud profile to tanzu?)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAW2QNALEJSHAL5D2LORET3SO3AAZANCNFSM4RXJEGKQ>.
|
Tools like We could move on to the more recent Whatever the solution, we have to find a way to customize the version/tag.
|
I hope that will progress on this issue. |
@patsevanton could you try |
Yes. I can pull How can i help for this issue ? |
@patsevanton could test to deploy the application into k8s with the image I've pushed into the |
Thanks for answer. Now testing spring-petclinic-cloud by skaffold. I will test later. |
I would like to publish the docker images to the
springcommunity
organization: https://hub.docker.com/u/springcommunity. So people could test k8s deployment without building the docker images.I didn't try but I suppose it will publish image without prefix (ie: springcommunity:vets-service)
To avoid naming conflict, could we add as prefix the name of the github project:
spring-petclinic-cloud
and a suffix with thek8s
maven profile ? Thus we will havespringcommunity:spring-petclinic-cloud-vets-service-k8s
What do you think about? Does docker image name and k8s service name are linked?
The text was updated successfully, but these errors were encountered: