🚀 Modernize and Upgrade

[maciejwalkowiak]

• upgrade to Spring Boot 2.3.0.RC1
• upgrade to JUnit 5
• use TestContainers instead of in-memory database
• integrate with Wavefront
• replace EhCache with Caffeine
• add Github Actions configuration

[arey]

Thank you Maciej for this major update.
I'm sure I could report some of your updates to other forks.
I have some questions for you:

• Do you think Caffeine is really better than EhCache? I have read their wiki page about EhCache but it's dated for 2015 and I don't know if argument's authors is always up to date?
• Does GitHub actions could replace Travis CI build? (ie. https://travis-ci.org/spring-petclinic/spring-framework-petclinic/)
• TestContainers required to have docker started. On my personal computer, it's not the case. The fork maintained by the Pivotal team does not required it. Thus I think the readme.md should mention it to avoid such error message:

Caused by: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration

• I didn't know Wavefront. Do you think it has its place in the distributed version of Spring Petclinic: https://github.com/spring-petclinic/spring-petclinic-microservices ?

[maciejwalkowiak]

Thanks @arey!

• Do you think Caffeine is really better than EhCache? I have read their wiki page about EhCache but it's dated for 2015 and I don't know if argument's authors is always up to date?

I can't say it's better but I find it much easier to configure and I've used it in heavy production scenarios with success. If you have any strong opinions about Ehcache I am also fine with bringing it back.

• Does GitHub actions could replace Travis CI build? (ie. https://travis-ci.org/spring-petclinic/spring-framework-petclinic/)

I believe so. I picked Github actions because "it just works" and it has no issues with Testcontainers.

• TestContainers required to have docker started. On my personal computer, it's not the case. The fork maintained by the Pivotal team does not required it. Thus I think the readme.md should mention it to avoid such error message:

Caused by: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration

It's true. I'll add it to readme. I live in bubble where Docker has become a standard tooling but you're right it's not always the case.

• I didn't know Wavefront. Do you think it has its place in the distributed version of Spring Petclinic: https://github.com/spring-petclinic/spring-petclinic-microservices ?

Yes I think microservices flavor is even better use case for Wavefront. @odedia https://github.com/odedia/spring-petclinic-microservices has already integrated it in his fork.

[arey]

Thank @maciejwalkowiak for all your answers.
Just 2 comments:

• I've created an issue to integrate Wavefront into the k8s fork (that is in stand-by).
• I don't have a strong opinion about Ehcache. I have been using it for over a decade in Production. It works great and I never look at other alternatives. Ca