Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Spring Cloud Finchley #72

Closed
arey opened this issue Mar 30, 2018 · 3 comments
Closed

Upgrade to Spring Cloud Finchley #72

arey opened this issue Mar 30, 2018 · 3 comments
Assignees
@arey
Labels
enhancement

Comments

@arey
Copy link
Member

arey commented Mar 30, 2018

Finchley is compatible with Spring Boot 2.
See https://spring.io/blog/2018/03/23/spring-cloud-finchley-m9-has-been-released
@arey arey self-assigned this Apr 11, 2018
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Apr 11, 2018
@arey
spring-petclinic#72 Upgrade to Spring Cloud Finchley M9
1241f78
@arey
Copy link
Member Author

arey commented Apr 11, 2018 •
edited
Loading

I've created a feature/Finchley branch: https://github.com/arey/spring-petclinic-microservices/tree/feature/Finchley

Datasource initialization failed at startup. Setting the parameter spring.datasource.initialization-mode: always displays a circular dependency:


The dependencies of some of the beans in the application context form a cycle:

   entityManagerFactory defined in class path resource [org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaConfiguration.class]
      ↓
   entityManagerFactoryBuilder defined in class path resource [org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaConfiguration.class]
      ↓
   jpaVendorAdapter defined in class path resource [org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaConfiguration.class]
┌─────┐
|  scopedTarget.dataSource defined in class path resource [org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration$Hikari.class]
↑     ↓
|  org.springframework.boot.autoconfigure.jdbc.DataSourceInitializerInvoker

@arey arey mentioned this issue Apr 11, 2018
Closed
@arey
Copy link
Member Author

arey commented Apr 15, 2018

Thinking the issue could be related to spring-projects/spring-boot#12374 I've tested Spring Boot 2.0.1, but it does not fixed it.

arey added a commit to arey/spring-petclinic-microservices that referenced this issue May 1, 2018
@arey
spring-petclinic#72 Upgrade to Spring Boot 2.0.1
a5afbcd
arey added a commit to arey/spring-petclinic-microservices that referenced this issue May 1, 2018
@arey
spring-petclinic#72 Remove @deprecated API usage
9e6eb12
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Jun 2, 2018
@arey
spring-petclinic#72 Upgrade to Spring Cloud Finchley RC2, Spring Boot…
1f4a7d8 
… 2.0.2, Sleuth 2.0.0.RC2, Zipkin Server 2.8.4
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Jun 6, 2018
@arey
spring-petclinic#72 Registering the index ViewController is no more r…
defbb52 
…equired
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Jun 6, 2018
@arey
spring-petclinic#72 Upgrade to Spring Boot Admin 2.0.0
3e4f7b0
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Jun 6, 2018
@arey
spring-petclinic#72 Add @NoArgsConstructor required for Jackson deser…
58c886d 
…ialization
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Jun 29, 2018
@arey
spring-petclinic#72 Upgrade to Spring Boot 2.0.3
a99c9b0
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Jun 29, 2018
@arey
spring-petclinic#72 Upgrade to Spring Cloud Finchley RELEASE
ef110f3
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Jul 11, 2018
@arey
spring-petclinic#72 changes requested by the @mszarlinski code review
50231b1
mszarlinski pushed a commit that referenced this issue Jul 14, 2018
@arey @mszarlinski
Upgrade to Spring Cloud Finchley #72 (#80)
ba03bfe 
* #72 Upgrade to Spring Cloud Finchley M9

* #72 Upgrade to Spring Boot 2.0.1

* #72 Remove @deprecated API usage

* #72 Upgrade to Spring Cloud Finchley RC2, Spring Boot 2.0.2, Sleuth 2.0.0.RC2, Zipkin Server 2.8.4

* #72 Registering the index ViewController is no more required

* For logging, implement the toString() method of the Pet entity

* #72 Upgrade to Spring Boot Admin 2.0.0

* #72 Add @NoArgsConstructor required for Jackson deserialization

* #72 Upgrade to Spring Boot 2.0.3

* #72 Upgrade to Spring Cloud Finchley RELEASE

* Change Zipkin local host URL

* #72 changes requested by the @mszarlinski code review
@arey arey closed this as completed Jul 15, 2018
@arey arey reopened this Jul 15, 2018
@arey arey mentioned this issue Jul 16, 2018
Merged
arey added a commit that referenced this issue Jul 16, 2018
@arey
Merge pull request #83 from spring-petclinic/feature/Finchley
8fa041c 
Upgrade to Spring Cloud Finchley #72
@arey
Copy link
Member Author

arey commented Jul 16, 2018

Meege into master

@arey arey closed this as completed Jul 16, 2018
talha-01 pushed a commit to talha-01/microservices-ci-cd-pipeline-with-petclinic-app that referenced this issue Nov 13, 2020
@arey @mszarlinski
Upgrade to Spring Cloud Finchley spring-petclinic#72 (spring-petclini…
3626cec 
…c#80)

* spring-petclinic#72 Upgrade to Spring Cloud Finchley M9

* spring-petclinic#72 Upgrade to Spring Boot 2.0.1

* spring-petclinic#72 Remove @deprecated API usage

* spring-petclinic#72 Upgrade to Spring Cloud Finchley RC2, Spring Boot 2.0.2, Sleuth 2.0.0.RC2, Zipkin Server 2.8.4

* spring-petclinic#72 Registering the index ViewController is no more required

* For logging, implement the toString() method of the Pet entity

* spring-petclinic#72 Upgrade to Spring Boot Admin 2.0.0

* spring-petclinic#72 Add @NoArgsConstructor required for Jackson deserialization

* spring-petclinic#72 Upgrade to Spring Boot 2.0.3

* spring-petclinic#72 Upgrade to Spring Cloud Finchley RELEASE

* Change Zipkin local host URL

* spring-petclinic#72 changes requested by the @mszarlinski code review
talha-01 pushed a commit to talha-01/microservices-ci-cd-pipeline-with-petclinic-app that referenced this issue Nov 13, 2020
@arey
Merge pull request spring-petclinic#83 from spring-petclinic/feature/…
29ad60e 
…Finchley

Upgrade to Spring Cloud Finchley spring-petclinic#72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arey arey

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arey