Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile and fix layers caching #148

Merged
merged 1 commit into from Mar 21, 2020
Merged

Update Dockerfile and fix layers caching #148

merged 1 commit into from Mar 21, 2020

Conversation

LukasForst
Copy link
Contributor

I updated the dockerfile - replaced ADD with RUN and thus allowed caching of the Dockerize.

RUN hashes just the URL, on the other hand ADD computes hash from the downloaded file so the file must be downloaded every time.

Step 1/12 : FROM openjdk:8-jre-alpine

 ---> f7a292bbb70c
Step 2/12 : VOLUME /tmp

 ---> Using cache
 ---> 674131380226
Step 3/12 : ARG DOCKERIZE_VERSION

 ---> Using cache
 ---> 4e71f5a79327
Step 4/12 : RUN wget -O dockerize.tar.gz https://github.com/jwilder/dockerize/releases/download/${DOCKERIZE_VERSION}/dockerize-alpine-linux-amd64-${DOCKERIZE_VERSION}.tar.gz

 ---> Using cache
 ---> f04603ca89a8
Step 5/12 : RUN tar xzf dockerize.tar.gz

 ---> Using cache
 ---> b3b45f125cc1
Step 6/12 : RUN chmod +x dockerize

 ---> Using cache
 ---> 06b6c870566e
Step 7/12 : ARG ARTIFACT_NAME

 ---> Using cache
 ---> 834646a63ccb

This fixes #136

@arey
Copy link
Member

arey commented Mar 21, 2020

Thanks a lot @LukasForst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid download dockerize-alpine-linux-amd64-v0.6.1.tar.gz
2 participants