Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipkin server is unavailable when running services with Docker #47

Merged
merged 1 commit into from
Feb 26, 2017

Conversation

mszarlinski
Copy link
Collaborator

I've prepared a fix for issue that I came across while running services with Docker. Accompanying fix for the config has been already commited: spring-petclinic/spring-petclinic-microservices-config@29118ee

@arey please review

@arey
Copy link
Member

arey commented Feb 26, 2017

I don't know if this behaviour is coming from Docker or by the fact the microservices are not running on the same localhost. But it should work in any cases by customizing the zipkin.baseUrl.

@mszarlinski
Copy link
Collaborator Author

Problem appears because Zipkin server is running in different container, so we should provide a link to it in docker-compose file.

@mszarlinski mszarlinski merged commit a993f56 into spring-petclinic:master Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants