Upgrade to JUnit 5.3.1 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arey
reviewed
Sep 24, 2018
| @@ -42,11 +46,13 @@ | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter-test</artifactId> | |||
| <scope>test</scope> | |||
| <exclusions> | |||
There was a problem hiding this comment.
In order to exclude the junit:junit dependency a single time, we could centralize the exclusion into the section of the parent POM
pom.xml
Outdated
| @@ -27,10 +27,14 @@ | |||
| </modules> | |||
|
|
|||
| <properties> | |||
| <assertj.version>3.9.0</assertj.version> | |||
| <java.version>1.8</java.version> | |||
| <junit.version>5.3.1</junit.version> | |||
There was a problem hiding this comment.
Do we still need the junit dependency? I'm note sure.
There was a problem hiding this comment.
I forgot versions are already provided from parent POM
pom.xml
Outdated
| @@ -55,6 +59,18 @@ | |||
| <scope>import</scope> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
junit-jupiter depencies are already declared into the Spring Boot 2.0.4 BOM
<junit-jupiter.version>5.1.1</junit-jupiter.version>
<junit-platform.version>1.1.0</junit-platform.version>
...
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<version>${junit-jupiter.version}</version>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>${junit-jupiter.version}</version>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>${junit-jupiter.version}</version>
</dependency>
talha-01
pushed a commit
to talha-01/microservices-ci-cd-pipeline-with-petclinic-app
that referenced
this pull request
Nov 13, 2020
Upgrade to JUnit 5.3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.