Upgrade jacoco to 0.8.11 such that we can build with JDK 21 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that building with JDK 17 and running with JDK 21 (including virtual threads support) works just fine, as long as we don't use virtual threads in our application because the Spring framework is packaged as a multi-release jar file. We only need to build with JDK 21 if we want to use 21 features in our application.
The jacoco upgrade is needed because jacoco tries to instrument some of the JDK classes and the current version 0.8.8 doesn't understand the JDK 21 classs if we are building with JDK 21.