Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove addDefaultPropertiesFileToTopModules flag #461

Closed
fabapp2 opened this issue Oct 3, 2022 · 5 comments · Fixed by #469
Closed

Refactor: Remove addDefaultPropertiesFileToTopModules flag #461

fabapp2 opened this issue Oct 3, 2022 · 5 comments · Fixed by #469

Comments

@fabapp2
Copy link
Collaborator

fabapp2 commented Oct 3, 2022

What needs to be done

Replace the addDefaultPropertiesFileToTopModules flag in AddSpringBootApplicationPropertiesAction with

if(context.getApplicationModules().isSingleModuleApplication()) {
  context.getApplicationModules()
                    .getRootModule()
                    ...
} else {
  context.getApplicationModules()
                    .getTopmostApplicationModules()
                    .stream()
                    .forEach(this::apply);
}
@ahmedmq
Copy link
Contributor

ahmedmq commented Oct 6, 2022

Hey @fabapp2 - Can I pick this one?

@AbhiVaidya95
Copy link

Hey @fabapp2 , I can pick this up?

@fabapp2
Copy link
Collaborator Author

fabapp2 commented Oct 6, 2022

Hey @fabapp2 - Can I pick this one?

picked-by: @ahmedmq

@fabapp2
Copy link
Collaborator Author

fabapp2 commented Oct 6, 2022

Hey @fabapp2 , I can pick this up?

@AbhiVaidya95 thanks for your interest. 🚀

Could you pick sonething else maybe? This issue came up after a change @ahmedmq did, so he's got all context.
I will update issues next days in case there's nothing that interests you now.

@ahmedmq
Copy link
Contributor

ahmedmq commented Oct 7, 2022

Thanks @fabapp2

ahmedmq added a commit to ahmedmq/spring-boot-migrator that referenced this issue Oct 7, 2022
fabapp2 added a commit to ahmedmq/spring-boot-migrator that referenced this issue Oct 7, 2022
fabapp2 added a commit to ahmedmq/spring-boot-migrator that referenced this issue Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants