Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logic from RewriteRecipeRunner into ProjectContext.apply(Recipe) #803

Closed
fabapp2 opened this issue Jun 13, 2023 · 2 comments · Fixed by #860
Closed

Move logic from RewriteRecipeRunner into ProjectContext.apply(Recipe) #803

fabapp2 opened this issue Jun 13, 2023 · 2 comments · Fixed by #860
Labels
good first issue Good for newcomers type: refactoring

Comments

@fabapp2
Copy link
Collaborator

fabapp2 commented Jun 13, 2023

What needs to be done

The logic from RewriteRecipeRunner.run(ProjectContext, Recipe) should be moved into ProjectContext.apply(Recipe) following the same concept as in other classes (e.g. OpenRewriteMavenBuildFile or OpenRewriteJavaSource).

Why it needs to be done

To use the same concept everywhere
@sourav15102
Copy link

Hi team,

I want to work on this issue.
I will refer to https://github.com/spring-projects-experimental/spring-boot-migrator/wiki/Spring-Boot-3-Upgrade-Report-Contribution-Guideline for contribution guidelines.

-Sourav

sourav15102 pushed a commit to sourav15102/spring-boot-migrator that referenced this issue Jul 11, 2023
Fixed issue spring-projects-experimental#803
8604a35
fabapp2 pushed a commit that referenced this issue Aug 5, 2023
@fabapp2
Fixed issue #803
c4095bd
fabapp2 added a commit that referenced this issue Aug 5, 2023
@fabapp2
Finish #803 (#860)
44fed8a 
* Fixed issue #803

* Remove RewriteRecipeRunner and change all client code

---------

Co-authored-by: Sourav <sr734546@dal.ca>
@fabapp2 fabapp2 linked a pull request Aug 5, 2023 that will close this issue
Finish #803 #860
Merged
@fabapp2
Copy link
Collaborator Author

fabapp2 commented Aug 5, 2023

Thanks for your PR @sourav15102.

@fabapp2 fabapp2 closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finish #803 spring-projects-experimental/spring-boot-migrator
2 participants
@sourav15102 @fabapp2