Autocompletion of scan directories and apply available recipes #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 25, 2022 23:42
|
Needs a slash |
timtebeek
changed the title
timtebeek
commented
Jul 23, 2022
| public List<CompletionProposal> complete(CompletionContext completionContext) { | ||
| ProjectContext projectContext = projectContextHolder.getProjectContext(); | ||
| List<Recipe> applicableRecipes = applicableRecipeListCommand.execute(projectContext); | ||
| return applicableRecipes.stream().map(Recipe::getName).map(CompletionProposal::new).toList(); |
There was a problem hiding this comment.
Figured this one is so simple and duplicates parts of ApplyShellCommand.apply, that it does not warrant it's own unit test.
|
Hi @timtebeek, I like the auto-completion. For path auto-completion, I think we could improve the handling a bit to make it easier to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128.
Tested locally through:
cd spring-boot-migrator/applications/spring-shell/mvn package -DskipTestsjava -jar target/spring-boot-migrator.jarscan <tab> ../../../ <tab>apply <tab> <tab>That should provide you with auto complete examples located next to
spring-boot-migrator.Followed by autocompletion of available recipes.