Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the jmx endpoint exposure related files . #473

Merged

Conversation

ishu-thakur
Copy link
Contributor

@ishu-thakur ishu-thakur commented Oct 8, 2022

Adding 3.0.0-M5: JMX Endpoint Exposure related code for issue #444

@pivotal-cla
Copy link

@ishu-thakur Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@ishu-thakur Thank you for signing the Contributor License Agreement!

@fabapp2 fabapp2 added this to the v0.13.0 milestone Oct 11, 2022
@fabapp2 fabapp2 added type: enhancement New feature or request upgrade:boot 3.0.0 Spring Boot 3.0.0 labels Oct 11, 2022
@fabapp2 fabapp2 added this to In progress in Spring Boot 3.0 Upgrade via automation Oct 11, 2022
@fabapp2 fabapp2 linked an issue Oct 11, 2022 that may be closed by this pull request
1 task
Copy link
Collaborator

@fabapp2 fabapp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ishu-thakur for this contribution 🚀

@fabapp2 fabapp2 force-pushed the jmx_endpoints_exposure branch 2 times, most recently from fe60164 to c84e07b Compare November 3, 2022 15:46
@ishu-thakur
Copy link
Contributor Author

Thank you @ishu-thakur for this contribution 🚀

Thank you @fabapp2 for giving me this chance and helping me out throughout and if help required or any other issue I am always open for it :)

@fabapp2
Copy link
Collaborator

fabapp2 commented Nov 3, 2022

Thank you @ishu-thakur for this contribution 🚀

Thank you @fabapp2 for giving me this chance and helping me out throughout and if help required or any other issue I am always open for it :)

Hi @ishu-thakur

You're very welcome. I am glad you are contributing 🤩
No offense, I moved the recipe to the "other" yaml myself as I want to get all PRs to main (trying to catch up).
I was not sure about your time and thought I'd do the little change myself to get your PR merged back.
Got into some merge conflicts with other stuff, that's why I am pushing changes to your PR right now...

@ishu-thakur
Copy link
Contributor Author

Got into some merge conflicts with other stuff,

@fabapp2 if you need any help or is there anything I can do I will love to do it .

@fabapp2
Copy link
Collaborator

fabapp2 commented Nov 3, 2022

Got into some merge conflicts with other stuff,

@fabapp2 if you need any help or is there anything I can do I will love to do it .

@ishu-thakur I'd say let me finish the mess I started.
But if you want to look into something else #248 will be the next important issue. If you like you can read into it, the description is rather incomplete but if you add a comment there that you'd like to pick it we can have a conversation about what to do and how to split work there?

@ishu-thakur
Copy link
Contributor Author

ishu-thakur commented Nov 3, 2022

o split work there?

@fabapp2 that sounds awesome to me . Sure we can split work there and let me go through the documentation .

@fabapp2 fabapp2 merged commit 6173834 into spring-projects-experimental:main Nov 3, 2022
Spring Boot 3.0 Upgrade automation moved this from In progress to Done Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0.0 Spring Boot 3.0.0 type: enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3.0.0-M5: JMX Endpoint Exposure
3 participants