Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp/945 decouple sbm support rewrite from maven #946

Merged
merged 14 commits into from
Sep 28, 2023
Merged

Revamp/945 decouple sbm support rewrite from maven #946

merged 14 commits into from
Sep 28, 2023

Conversation

fabapp2
Copy link
Collaborator

@fabapp2 fabapp2 commented Sep 28, 2023 •
edited
Loading

The project builds and tests are green.

The dependency on Maven classes that require File and thus file system access has been removed.
The order of Maven projects is calculated in MavenProjectAnalyzer.
It creates the same result as the previously used Maven classes.
Maven plugins and plugin dependencies are currently ignored.

However, the classpath resolution for multi-module projects is broken.
Correct classpath resolution will also allow fixing #879 and #871.

Related open tasks:

@fabapp2
WIP: Calculate reactor build order
c6afc4a 
- Replace MavenProject
- Provide Analyzer for order and test
- Missing: Maven plugin order and tests
@fabapp2
Cleanup
830eb2c
@fabapp2
SbmMavenProject
bc863f7
@fabapp2
WIP
f1e4939 
* Copied Java parsing from MavenMojoProjectParser
* SbmMavenProject provides more methods
* Resources used to collect java sources
@fabapp2
WIP
2074c49 
* Only test with classpath fails
@fabapp2
WIP
a8cdc8a 
* Parsing single module project works
* Classpath resolved
@fabapp2
WIP - problems with duplicate resource parsing
be65784
@fabapp2
Build successful
7e1ba92
@fabapp2
Add ProjectId for Maven projects
ccf41ed
@fabapp2 fabapp2 self-assigned this Sep 28, 2023
@fabapp2 fabapp2 linked an issue Sep 28, 2023 that may be closed by this pull request
Decouple sbm-support-rewrite from Maven #945
Closed
@fabapp2
Remove broken import
0952a8b
@fabapp2
Decoupled main from non-required Maven deps
7b57a50 
* Moved all Maven related classes not required by RewriteProjectParser to test
* Set Maven dependencies to test scope where possible
@fabapp2 fabapp2 changed the base branch from main to version/revamp September 28, 2023 20:07
@fabapp2
Remove conflicting deps and add missing ones
8d98337 
* Adjust code to missing dependencies previously transitively available
@fabapp2
Remove conflicting deps and add missing ones
a10cc18 
* Adjust code to missing dependencies previously transitively available
@fabapp2
Fix build action
312a39a
@fabapp2 fabapp2 merged commit 4a3e42e into version/revamp Sep 28, 2023
2 checks passed
@fabapp2 fabapp2 deleted the revamp/945-decouple-sbm-support-rewrite-from-maven branch September 28, 2023 21:48
@fabapp2 fabapp2 mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabapp2 fabapp2

Labels
revamp type: refactoring
Projects
Revamp
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decouple sbm-support-rewrite from Maven
1 participant
@fabapp2