Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect the presence of autoconfig for Brave #38

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Detect the presence of autoconfig for Brave #38

merged 1 commit into from
Mar 30, 2021

Conversation

jonatan-ivanov
Copy link
Collaborator

  • Detect the presence of autoconfig for Brave
  • Fail the context initialization if it presents
  • Let the user know that they need to pics one tracer

fixes #36

@jonatan-ivanov
Detect the presence of autoconfig for Brave, fail the context initial…
c5eb28a 
…ization if it present and let the user know that they need to pics one tracer.
@jonatan-ivanov jonatan-ivanov self-assigned this Mar 22, 2021
@marcingrzejszczak marcingrzejszczak added the enhancement New feature or request label Mar 30, 2021
@marcingrzejszczak marcingrzejszczak added this to the 1.0.0-M6 milestone Mar 30, 2021
@marcingrzejszczak marcingrzejszczak merged commit 62adab8 into master Mar 30, 2021
@marcingrzejszczak marcingrzejszczak removed this from the 1.0.0-M6 milestone Mar 30, 2021
@jonatan-ivanov jonatan-ivanov deleted the gh-36_tracer-detection branch March 30, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcingrzejszczak marcingrzejszczak Awaiting requested review from marcingrzejszczak

Assignees

@jonatan-ivanov jonatan-ivanov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail the context to start if both Brave and OTel is on the classpath
2 participants
@jonatan-ivanov @marcingrzejszczak