-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Okhttp tracing support #38
Conversation
@Configuration | ||
@ConditionalOnClass(TraceContext.class) | ||
@ConditionalOnBean({ CurrentTraceContext.class, HttpClientHandler.class }) | ||
@ConditionalOnProperty(value = "okhttp.tracing.enabled", havingValue = "true", matchIfMissing = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general all spring related projects should have spring.
prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right; I did it this way, cause there were other existing properties prefixed like this, but I'll convert all of them in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two broad rules that we try to follow: Avoid "via" (part of our initiative to avoid Latin terms) and remove "out of the box" (because it rarely adds any information).
Thanks.
Fixes gh-36.