Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API doc links optional #6

Closed
wilkinsona opened this issue May 13, 2014 · 4 comments
Closed

Make API doc links optional #6

wilkinsona opened this issue May 13, 2014 · 4 comments

Comments

@wilkinsona
Copy link
Member

This is somewhat similar to spring-attic/sagan#388.

The Spring IO Platform doesn't have any API docs which causes a minor glitch on its project page as the reference docs link is rendered with a separator even though there's no API docs link for it to be separated from. I've worked around the problem with my own changes but I wonder if a more general-purpose solution might be possible.

@dsyer
Copy link
Member

dsyer commented Sep 30, 2014

That change looks worthy of a pull request to me.

@wilkinsona
Copy link
Member Author

The CSS change in my hack isn't generally applicable. For projects that have both API docs and reference docs my change will get rid of the separator that goes between them.

@gregturn
Copy link
Contributor

gregturn commented Aug 4, 2015

Looking into things, it appears the simplest fix is to put conditional checks at https://github.com/spring-projects/gh-pages/blob/gh-pages/_includes/widget_templates.html#L20-L23. I can work on this since I've recently done some hacking on underscore.js templates.

bclozel added a commit that referenced this issue Aug 18, 2015
Conditionalize reference doc/api doc links
@bclozel
Copy link
Member

bclozel commented Aug 18, 2015

Fixed by #12

@bclozel bclozel closed this as completed Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants