Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ollama] Missing fields in API #553

Closed
ThomasVitale opened this issue Apr 6, 2024 · 0 comments · Fixed by #554
Closed

[Ollama] Missing fields in API #553

ThomasVitale opened this issue Apr 6, 2024 · 0 comments · Fixed by #554

Comments

@ThomasVitale
Copy link
Contributor

The keep_alive field in the Ollama requests objects are missing. (option that might become more configurable in #549)
The images field in the Generation request object is missing.

See: https://github.com/ollama/ollama/blob/main/api/types.go

ThomasVitale added a commit to ThomasVitale/spring-ai that referenced this issue Apr 6, 2024
Fixes spring-projectsgh-553

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
tzolov pushed a commit that referenced this issue Apr 6, 2024
Fixes gh-553

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
bmoussaud pushed a commit to bmoussaud/spring-ai that referenced this issue Apr 9, 2024
Fixes spring-projectsgh-553

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
JM-Lab pushed a commit to JM-Lab/spring-ai that referenced this issue Apr 17, 2024
Fixes spring-projectsgh-553

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant