Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElasticsearchVectorStore add support for configuration. #633

Conversation

maxjiang153
Copy link
Contributor

Add ElasticsearchVectorStore support for creating index configuration. such as dims, denseVectorIndexing and similarity.

Also, include support for adding documents to ES with a failed response; this change will result in an exception.

@tzolov tzolov self-assigned this Apr 26, 2024
@tzolov tzolov added enhancement New feature or request vectors store labels Apr 26, 2024
@tzolov tzolov added this to the 1.0.0-M1 milestone Apr 30, 2024
@tzolov
Copy link
Collaborator

tzolov commented Apr 30, 2024

Thanks @wmz7year ,
We're still considering adding the concept of runtime options to the VectorStores (similar to the model clients). Anyway this PR is a step in this direction if we get there eventually.

@

@tzolov
Copy link
Collaborator

tzolov commented Apr 30, 2024

Rebased, squashed and merged at f90c51a

Additionally rename the dims property into dimension.
Add javadoc and antora ES properties documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vectors store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants