Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling CREATE KEYSPACE|TABLE IF NOT EXISTS … unnecessarily #655

Merged

Conversation

michaelsembwever
Copy link
Contributor

This also is a fix for AstraDB, which throws an exception if you try to CREATE KEYSPACE IF NOT EXISTS …

This PR looks like more change than it really is.

It is actually only two lines, the body of both the ensureKeyspaceExists() and ensureTableExists(..) methods are wrapped in an if statement.

@tzolov tzolov self-assigned this Apr 30, 2024
@tzolov tzolov added this to the 1.0.0-M1 milestone Apr 30, 2024
This also is a fix for AstraDB, which throws an exception if you try to `CREATE KEYSPACE IF NOT EXISTS …`
And use more compatible `USING 'StorageAttachedIndex'` index creation syntax.
@tzolov tzolov merged commit ac1a0d6 into spring-projects:main May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants